Fix #10 #11
Closed
Fix #10 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alorma! Do you think you'll be able to move on with this draft? |
|
Oh @alorma, I was just asking! The tests you added are a great beginning... Will you reopen this PR if I create a new branch on the project where we/you/someone else can move on with this fix? |
|
I don't have much time to work on this now, but i will support (even coding) if not alone :$ |
|
Great @alorma !!! I've just created a new branch change-definition-of-mention You can reopen this PR pointing to that new branch so we can accept it and get that great tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to implement #10